JH-A-Kim commented on PR #68106: URL: https://github.com/apache/airflow/pull/68106#issuecomment-4653546758
When I was working on this pr I saw that a few test cases specifically on test_triggerer.py were failing. These tests being ```ERROR airflow-core/tests/unit/jobs/test_triggerer_job.py::test_heartbeat_raises_without_job - TypeError: TriggerRunnerSupervisor.__init__() missing 1 required keyword-only argument: 'client' ERROR airflow-core/tests/unit/jobs/test_triggerer_job.py::test_metric_tags_raises_without_job - TypeError: TriggerRunnerSupervisor.__init__() missing 1 required keyword-only argument: 'client' ERROR airflow-core/tests/unit/jobs/test_triggerer_job.py::test_emit_metrics_uses_metric_tags_override - TypeError: TriggerRunnerSupervisor.__init__() missing 1 required keyword-only argument: 'client' ERROR airflow-core/tests/unit/jobs/test_triggerer_job.py::test_load_triggers_raises_without_job - TypeError: TriggerRunnerSupervisor.__init__() missing 1 required keyword-only argument: 'client' ERROR airflow-core/tests/unit/jobs/test_triggerer_job.py::test_create_workload_uses_supervisor_id_without_job - TypeError: TriggerRunnerSupervisor.__init__() missing 1 required keyword-only argument: 'client' ERROR airflow-core/tests/unit/jobs/test_triggerer_job.py::test_trigger_logger_fd_closed_when_upload_to_remote_raises - TypeError: TriggerRunnerSupervisor.__init__() missing 1 required keyword-only argument: 'client' FAILED airflow-core/tests/unit/jobs/test_triggerer_job.py::test_supervisor_stores_team_name - TypeError: TriggerRunnerSupervisor.__init__() missing 1 required keyword-only argument: 'client' FAILED airflow-core/tests/unit/jobs/test_triggerer_job.py::test_run_invokes_seams_in_order - TypeError: TriggerRunnerSupervisor.__init__() missing 1 required keyword-only argument: 'client' FAILED airflow-core/tests/unit/jobs/test_triggerer_job.py::test_client_delegates_to_make_client_and_caches_result - TypeError: TriggerRunnerSupervisor.__init__() missing 1 required keyword-only argument: 'client' FAILED airflow-core/tests/unit/jobs/test_triggerer_job.py::test_run_context_exits_when_subprocess_dies - TypeError: TriggerRunnerSupervisor.__init__() missing 1 required keyword-only argument: 'client' FAILED airflow-core/tests/unit/jobs/test_triggerer_job.py::test_heartbeat_watchdog - TypeError: TriggerRunnerSupervisor.__init__() missing 1 required keyword-only argument: 'client' FAILED airflow-core/tests/unit/jobs/test_triggerer_job.py::test_heartbeat_watchdog_disabled_when_threshold_is_zero - TypeError: TriggerRunnerSupervisor.__init__() missing 1 required keyword-only argument: 'client' FAILED airflow-core/tests/unit/jobs/test_triggerer_job.py::test_metric_tags_default_uses_job_hostname - TypeError: TriggerRunnerSupervisor.__init__() missing 1 required keyword-only argument: 'client' FAILED airflow-core/tests/unit/jobs/test_triggerer_job.py::test_load_triggers_passes_team_name - TypeError: TriggerRunnerSupervisor.__init__() missing 1 required keyword-only argument: 'client' FAILED airflow-core/tests/unit/jobs/test_triggerer_job.py::test_trigger_lifecycle - TypeError: TriggerRunnerSupervisor.__init__() missing 1 required keyword-only argument: 'client' FAILED airflow-core/tests/unit/jobs/test_triggerer_job.py::test_trigger_log[trigger0-0-1] - TypeError: TriggerRunnerSupervisor.__init__() missing 1 required keyword-only argument: 'client' FAILED airflow-core/tests/unit/jobs/test_triggerer_job.py::test_trigger_log[trigger1-1-0] - TypeError: TriggerRunnerSupervisor.__init__() missing 1 required keyword-only argument: 'client' FAILED airflow-core/tests/unit/jobs/test_triggerer_job.py::test_trigger_logger_fd_closed_when_removed - TypeError: TriggerRunnerSupervisor.__init__() missing 1 required keyword-only argument: 'client' FAILED airflow-core/tests/unit/jobs/test_triggerer_job.py::test_trigger_create_race_condition_38599 - TypeError: TriggerRunnerSupervisor.__init__() missing 1 required keyword-only argument: 'client' FAILED airflow-core/tests/unit/jobs/test_triggerer_job.py::test_trigger_runner_exception_stops_triggerer - TypeError: TriggerRunnerSupervisor.__init__() missing 1 required keyword-only argument: 'client' FAILED airflow-core/tests/unit/jobs/test_triggerer_job.py::test_failed_trigger - TypeError: TriggerRunnerSupervisor.__init__() missing 1 required keyword-only argument: 'client' FAILED airflow-core/tests/unit/jobs/test_triggerer_job.py::test_trigger_can_call_variables_connections_and_xcoms_methods - TypeError: TriggerRunnerSupervisor.__init__() missing 1 required keyword-only argument: 'client' FAILED airflow-core/tests/unit/jobs/test_triggerer_job.py::test_trigger_can_fetch_trigger_dag_run_count_and_state_in_deferrable - TypeError: TriggerRunnerSupervisor.__init__() missing 1 required keyword-only argument: 'client' FAILED airflow-core/tests/unit/jobs/test_triggerer_job.py::test_trigger_can_fetch_dag_run_count_ti_count_in_deferrable - TypeError: TriggerRunnerSupervisor.__init__() missing 1 required keyword-only argument: 'client' FAILED airflow-core/tests/unit/jobs/test_triggerer_job.py::test_update_triggers_prevents_duplicate_creation_queue_entries - TypeError: TriggerRunnerSupervisor.__init__() missing 1 required keyword-only argument: 'client' FAILED airflow-core/tests/unit/jobs/test_triggerer_job.py::test_update_triggers_delegates_workload_creation - TypeError: TriggerRunnerSupervisor.__init__() missing 1 required keyword-only argument: 'client' FAILED airflow-core/tests/unit/jobs/test_triggerer_job.py::test_update_triggers_uses_fetch_hooks - TypeError: TriggerRunnerSupervisor.__init__() missing 1 required keyword-only argument: 'client' FAILED airflow-core/tests/unit/jobs/test_triggerer_job.py::test_update_triggers_prevents_duplicate_creation_queue_entries_with_multiple_triggers - TypeError: TriggerRunnerSupervisor.__init__() missing 1 required keyword-only argument: 'client' FAILED airflow-core/tests/unit/jobs/test_triggerer_job.py::test_update_triggers_skips_when_ti_has_no_dag_version - TypeError: TriggerRunnerSupervisor.__init__() missing 1 required keyword-only argument: 'client' ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
