dazza-codes commented on a change in pull request #6811: [AIRFLOW-6245] Add
custom waiters for AWS batch jobs
URL: https://github.com/apache/airflow/pull/6811#discussion_r362264746
##########
File path: tests/test_core_to_contrib.py
##########
@@ -810,12 +812,21 @@
"airflow.providers.amazon.aws.sensors.sqs.SQSSensor",
"airflow.contrib.sensors.aws_sqs_sensor.SQSSensor",
),
+]
+PROTOCOLS = [
+ (
+ "airflow.providers.amazon.aws.hooks.batch_client.AwsBatchProtocol",
+ "airflow.contrib.operators.awsbatch_operator.BatchProtocol",
+ ),
]
-ALL = HOOK + OPERATOR + SENSOR
+
+
+ALL = HOOK + OPERATOR + SENSOR + PROTOCOLS
+
RENAMED_HOOKS = [
(old_class, new_class)
- for old_class, new_class in ALL
+ for old_class, new_class in HOOK + OPERATOR + SENSOR
Review comment:
Since @nuclearpinguin asked for the migration of the protocol to get tested
and he approved these changes, I'll assume this is good enough to resolve this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
