anmolxlight commented on PR #68239: URL: https://github.com/apache/airflow/pull/68239#issuecomment-4654516698
Thanks for the review @kaxil. I've addressed your feedback: instead of checking `remote_logging` at the `upload_to_remote()` call site, the code now computes `remote_logging_expected` at load time based on whether a custom `logging_config_class` is set or `remote_logging=True`, and stores that flag in `_ActiveLoggingConfig`. The warning gates on that pre-computed flag. Changes across 3 files: - `task-sdk/src/airflow/sdk/log.py`: added `remote_logging_expected` to `_ActiveLoggingConfig`, compute it in `_load_logging_config()`, use it in `upload_to_remote()` - `airflow-core/src/airflow/logging_config.py`: same pattern for the core path - `task-sdk/tests/task_sdk/test_log.py`: updated tests to set the flag directly instead of mocking conf -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
