I-am-Uchenna commented on PR #67901: URL: https://github.com/apache/airflow/pull/67901#issuecomment-4658852057
Yes, ready for review. The latest commit (a7a1e81) addresses the review feedback by eliminating `os.fork()` entirely rather than suppressing the warning. The approach splits task instance event emission into two phases: 1. **Phase 1 (parent process)**: Metadata extraction and facet building, where ORM objects are available 2. **Phase 2 (ProcessPoolExecutor with forkserver)**: Event construction and emission via the new `_emit_task_instance_event` module-level function This follows the same pattern already used by `_on_task_instance_manual_state_change` and the DAG-run listeners. The intermediate commits (warning suppression, threading attempt) are superseded by this final commit. Removed: `_fork_execute`, `_terminate_with_wait`, `_execute`, and unused imports (`os`, `psutil`, `setproctitle`, `configure_orm`). Note: the branch needs rebasing against main, and the PR description should be updated to reflect the current approach. Happy to do both if a maintainer confirms the direction looks right. cc @mobuchowski @kacpermuda -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
