namratachaudhary commented on code in PR #68213:
URL: https://github.com/apache/airflow/pull/68213#discussion_r3381341025
##########
shared/observability/src/airflow_shared/observability/metrics/metrics_template.yaml:
##########
@@ -59,6 +59,27 @@ metrics:
legacy_name: "operator_successes_{operator_name}"
name_variables: ["operator_name"]
+ - name: "resumable_job.fresh_submit"
Review Comment:
The YAML describes resumable_job.fresh_submit as firing when "no prior run
ID found." In practice the counter increments in three cases:
- A first run (no stored ID)
- A prior job that ended in a terminal/failed state, triggering a fresh
submit
- task_store is unavailable
Either update the description to match what the code actually does (for
example: "submitted a fresh job — first run, resubmit after a failed job, or no
task_store available") or split it into separate counters if we want to tell
these cases apart in metrics.
##########
shared/observability/src/airflow_shared/observability/metrics/metrics_template.yaml:
##########
@@ -59,6 +59,27 @@ metrics:
legacy_name: "operator_successes_{operator_name}"
name_variables: ["operator_name"]
+ - name: "resumable_job.fresh_submit"
Review Comment:
The YAML describes resumable_job.fresh_submit as firing when "no prior run
ID found." In practice the counter increments in three cases:
- A first run (no stored ID)
- A prior job that ended in a terminal/failed state, triggering a fresh
submit
- task_store is unavailable
Either update the description to match what the code actually does (for
example: "submitted a fresh job, first run, resubmit after a failed job, or no
task_store available") or split it into separate counters if we want to tell
these cases apart in metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
