bbovenzi commented on PR #68200: URL: https://github.com/apache/airflow/pull/68200#issuecomment-4662216127
> @bbovenzi Just to make sure I understand the suggestion correctly, are you primarily looking for: > > * A single source of truth for shortcut definitions (e.g. a central catalog/JSON file), while keeping the dialog scoped to shortcuts available on the current page? > * The help dialog itself to always show the complete list of shortcuts, regardless of the current page? > > The current implementation intentionally uses the live registry so the dialog only shows shortcuts that are actually available in the current context. The first one. I think having a single source of truth in the code would help with maintainability. We can have nested objects in the json block for global vs per page shortcuts though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
