JH-A-Kim commented on code in PR #68106:
URL: https://github.com/apache/airflow/pull/68106#discussion_r3384834477
##########
airflow-core/src/airflow/jobs/triggerer_job_runner.py:
##########
@@ -542,66 +526,33 @@ def _handle_request(self, msg: ToTriggerSupervisor, log:
FilteringBoundLogger, r
except Exception:
log.exception("Failed to upload trigger logs to
remote", trigger_id=id)
finally:
- # Close the FD explicitly even if upload raised,
otherwise the file
- # handle leaks for every failed upload.
factory.close()
-
- response = messages.TriggerStateSync(
- to_create=[],
- to_cancel=self.cancelling_triggers,
- )
-
- # Pull out of these dequeues in a thread-safe manner
+ sync = messages.TriggerStateSync(to_create=[], to_cancel=set())
+ sync.to_cancel = self.cancelling_triggers.copy()
Review Comment:
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
