ersalil commented on PR #68284: URL: https://github.com/apache/airflow/pull/68284#issuecomment-4669659606
Thanks a lot for the review, @kaxil! I've pushed the changes: - Pulled the safety check into a _is_recordable() helper so all six recording methods (incr, decr, gauge, timing, timer) share the same guard and none can miss it. - Fixed the mypy narrowing (str | None → str) it surfaced. All CI checks are green now. Really appreciate the guidance — let me know if there's anything else you'd like me to adjust! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
