ashb commented on PR #68377: URL: https://github.com/apache/airflow/pull/68377#issuecomment-4680869705
> > `[other coroutine] send() → tries _thread_lock.acquire()` > > That should never be allowed to happen. We need to detect why sync send is being run on the async loop and trampoline back to the async version instead. > > This is because of the mask_secret, which is sync, but the get_async_conn connection in msgraph is async, and it also logs some connection details (except password ofc), but the mask_secret is still applied anyway. We could add detection, but as mask_secret is sync, it would then crash anyway, but at least we would know why. That's why it was so difficult to track and why I didn't have the issue with SFTPAsyncHook That doesn't make sense to me. `mask_secret` is a function which makes no network requests - it just applies masks based on what it is given. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
