pierrejeambrun commented on code in PR #67594:
URL: https://github.com/apache/airflow/pull/67594#discussion_r3396164399
##########
airflow-core/src/airflow/api_fastapi/core_api/datamodels/dag_run.py:
##########
@@ -80,6 +81,8 @@ def validate_model(cls, data: Any) -> Any:
"""Validate clear Dag run form."""
if data.get("only_new") and data.get("only_failed"):
raise ValueError("only_new and only_failed are mutually exclusive")
+ if data.get("only_new") and data.get("only_skipped"):
+ raise ValueError("only_new and only_skipped are mutually
exclusive")
Review Comment:
Should we guard for "only_failed" and "only_skipped" being mutually
exclusive.
Since in `airflow-core/src/airflow/serialization/definitions/dag.py` state
are additive, this will actually clear both `failed` and `skipped` not
respecting the `only_state` parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
