xBis7 commented on code in PR #68393: URL: https://github.com/apache/airflow/pull/68393#discussion_r3397360245
########## shared/observability/src/airflow_shared/observability/metrics/__init__.py: ########## @@ -14,3 +14,193 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. +from __future__ import annotations Review Comment: This isn't a good place for configuring OTel metrics. `traces` uses the `__init__.py` file because it has been agreed that OTel will be the only supported implementation for traces across Airflow. But for metrics, multiple backends are supported. This code belongs under `otel_logger.py` unless it's shared between all the different loggers in this directory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
