jscheffl commented on PR #68362: URL: https://github.com/apache/airflow/pull/68362#issuecomment-4685557274
@bbovenzi Thanks for the re-placement of the Note! This is a bit feeling like the proposal I had a longer time ago in https://github.com/apache/airflow/pull/51764 with a bit improved folding. This improves for the proposed AIP-102 already 10% of what we need/want :-) - FYI @AutomationDev85 I think is better than before 3.3.0, but two nit to be considering from my view: 1) When navigating from a task to another (or to a run) the initial display of the note is always "folded to a single line" - this is good to save space but for a user it is not obvious that there it more than one line until he / she clicks. Is there any visual possible to inform that there is more than one line? Else in-experienced users might miss all from the second line and medium experienced users maybe only catch the first intro. 2) (Also a problem in 3.0, 3.1 and 3.2): If a link is rendered in Markdown then is is well displayed, but clicking on it gets user to edit mode. You basically need to copy&paste a markdown link and open manually. Is there an option to have the z-index with priority that a click on a link is respecting the link and edit mode is only made when you click not on a link? 3) I see there is no length validation in the new note. Notes (unfortunately) are limited to 1000 chars (maybe I need to contribute a feature allowing it to be more like a CLOB... 1000 chars as markdown might be a bit limiting...) - If you type more you just get an error that saving failed. https://github.com/user-attachments/assets/54cc5146-ae6e-44f2-93c0-5e6dba52e4ed P.S.: @dheerajturaga I rememebr you also would LOVE to have this in 3.3.0? :-D -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
