dkranchii opened a new pull request, #68415:
URL: https://github.com/apache/airflow/pull/68415
Two `# type: ignore[override]` annotations on `ExecutionAPISecretsBackend`
are no longer needed; removing them lets mypy verify the override contract
for real instead of silencing it.
- **`aget_connection`**: `BaseSecretsBackend` has no `aget_connection` (it
is sync-only), so `[override]` cannot fire — there is nothing to
override.
- **`get_connection`**: signature now matches the base exactly after
multi-team added `team_name` to `BaseSecretsBackend.get_connection`;
the override only narrows the return type to `Connection | None`, which
is a covariant return and accepted. The same pattern is used without
the ignore in `providers/hashicorp/.../vault.py`,
`providers/akeyless/.../akeyless.py`, and
`airflow-core/.../local_filesystem.py`.
Internal type-only cleanup; no runtime behaviour change, no newsfragment.
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Claude
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
