jason810496 commented on code in PR #68133:
URL: https://github.com/apache/airflow/pull/68133#discussion_r3401039737
##########
task-sdk/src/airflow/sdk/execution_time/context.py:
##########
Review Comment:
Not-blocking, but I just realized that `task_store` and `asset_store` only
recommend to store the metadata instead of large payload even with custom
object store backend e.g. the model checkpoint.
Would it be better to introduce a "what not to store" section in
`task-store.rst` as follow-up?
##########
task-sdk/src/airflow/sdk/execution_time/context.py:
##########
@@ -724,6 +739,18 @@ def set(self, key: str, value: JsonValue) -> None:
ref = backend.serialize_asset_store_to_ref(value=value, key=key,
scope=scope)
stored = _wrap_external_ref(ref)
+ limit = conf.getint("state_store", "max_value_storage_bytes")
+ if limit > 0:
Review Comment:
```suggestion
if ((limit := conf.getint("state_store", "max_value_storage_bytes"))
> 0):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
