dabla commented on PR #68344:
URL: https://github.com/apache/airflow/pull/68344#issuecomment-4688096537
Thanks for the PR.
I think this may introduce a breaking change for existing connections.
Previously we passed `account_url` to `AzureBlobFileSystem` using:
```python
options = {
"account_url": parse_blob_account_url(conn.host, conn.login),
}
```
but this has now been replaced with deriving and passing `account_name`
instead:
```python
account_name = _get_default_account_name(conn_type, conn.host, conn.login)
if account_name:
options["account_name"] = account_name
```
This means existing connections that rely on `account_url` semantics (for
example custom endpoints) may no longer work after upgrading the provider.
Provider connection changes should always remain backward compatible, and
existing connections must not be impacted by an upgrade. Am I missing
something, or should we continue supporting the previous `account_url` behavior
for backward compatibility?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
