amoghrajesh opened a new pull request, #68438:
URL: https://github.com/apache/airflow/pull/68438
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [x] Yes: claude sonnet 4.6
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
### What
Renames `task_store` / `asset_store` to `task_state_store` /
`asset_state_store` across the codebase. This is a **purely mechanical
rename**, no logic, behaviour, or API contract changes.
### Why
@ashb flagged the name `AssetStore` as a significant naming issue: it
implies storing actual asset data (potentially GBs of files/objects), whereas
these stores hold lightweight state metadata such as job IDs, watermarks,
cursors, coordination tokens. The suffix `StateStore` makes the intent
unambiguous.
### Proposed change
Rename everything to `TaskStateStore` / `AssetStateStore` to make the intent
clear. Scope of the rename:
- **Models**: `TaskStoreModel` -> `TaskStateStoreModel`, `AssetStoreModel` →
`AssetStateStoreModel`
- **DB cleanup service**: `MetastoreStoreBackend` ->
`MetastoreStateStoreBackend`
- **Execution API**: datamodels, route handlers, Cadwyn version schemas
- **Core API**: datamodels, route handlers, OpenAPI spec — URL path `/store`
-> `/state-store`
- **CLI**: `cleanup-task-store` -> `cleanup-task-state-store`
- **Task SDK**: `TaskStateStoreOperations`, `AssetStateStoreOperations`,
context keys `task_state_store` / `asset_state_store`, comms models
- **UI**: page components, generated OpenAPI client, i18n strings
- **Docs**: all RST files and toctree entries
- **Tests**: all affected test files and fixtures
> Note: Execution API URL paths `/store/ti` and `/store/asset` are
**intentionally unchanged** — workers already use them and changing them would
require a versioned migration for no benefit.
### Testing
Most of the testing here is for sanity purpose
1. DB sanity
<img width="1728" height="1031" alt="image"
src="https://github.com/user-attachments/assets/b3bf5953-98f9-4907-a9f0-fa431d1c771e";
/>
<img width="1728" height="1031" alt="image"
src="https://github.com/user-attachments/assets/3823f4d2-56e8-4c7c-b8ec-12df55067637";
/>
2. Example dags run fine
<img width="1728" height="917" alt="image"
src="https://github.com/user-attachments/assets/688c17b4-e2da-4900-8404-02e1ac7ab624";
/>
<img width="1728" height="902" alt="image"
src="https://github.com/user-attachments/assets/65f25ea7-cb08-4b8f-8e22-9cb7d1302fc6";
/>
<img width="1728" height="902" alt="image"
src="https://github.com/user-attachments/assets/99071034-311f-499e-b0a4-25cc5df9dec9";
/>
3. UI renders well
<img width="1728" height="902" alt="image"
src="https://github.com/user-attachments/assets/c4cc003b-c8ab-4a93-bacc-8ad83072e64e";
/>
<img width="914" height="902" alt="image"
src="https://github.com/user-attachments/assets/56865ae8-9a59-4022-a21e-37e985e23a8e";
/>
(Since these use public APIs, we should be good)
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
