choo121600 commented on code in PR #68397:
URL: https://github.com/apache/airflow/pull/68397#discussion_r3403464260
##########
airflow-core/src/airflow/ui/src/utils/hitl.ts:
##########
@@ -120,7 +120,7 @@ export const getHITLParamsDict = (
const paramData = hitlDetail.params[key] as ParamsSpec | undefined;
// Check if there's a preloaded value from URL params
- let finalValue = preloadedHITLParams[key] ?? value;
+ let finalValue = hitlDetail.params_input?.[key] ?? value;
Review Comment:
For pending tasks, `value` is the param spec object ({ value, schema,
description }), so with no `params_input` the field ends up rendering `[object
Object]`.
Would it make sense to use the param default before falling back to `value`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
