Lee-W commented on code in PR #68490:
URL: https://github.com/apache/airflow/pull/68490#discussion_r3407243378
##########
providers/microsoft/azure/tests/unit/microsoft/azure/hooks/test_wasb.py:
##########
@@ -364,7 +371,9 @@ def test_sas_token_connection(self, conn_id_str, extra_key):
assert conn.url.startswith("https://")
if hook_conn.login:
assert hook_conn.login in conn.url
- assert conn.url.endswith(sas_token + "/")
+ # The SAS token must be carried in the URL query string so the SDK
signs requests with
+ # it.
+ assert sas_token.lstrip("?") in conn.url
Review Comment:
since these things are static and not too long or complicated, I think we
can check the whole string
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]