GayathriSrividya commented on PR #68499:
URL: https://github.com/apache/airflow/pull/68499#issuecomment-4697770046

   @ashb  could you please take another look when you have a moment?
   
   I’ve addressed the points from your earlier review:
   
   Removed the redundant sub claim merge in the JWT reissue middleware and now 
use the claims already cached in request scope.
   Renamed the fixture from 
[client](vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/code/electron-browser/workbench/workbench.html)
 to 
[jwt_bearer_client](vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/code/electron-browser/workbench/workbench.html)
 so its purpose is explicit and less generic.
   Kept the test-docstring wording adjustment about request start vs middleware 
timing.
   Behavior-wise, the intent is unchanged: middleware no longer revalidates the 
bearer token and instead refreshes from the already-validated scope claims.
   
   Thanks again for the guidance and review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to