uranusjr commented on code in PR #68022:
URL: https://github.com/apache/airflow/pull/68022#discussion_r3407923571


##########
providers/apache/hdfs/src/airflow/providers/apache/hdfs/assets/hdfs.py:
##########
@@ -26,10 +27,12 @@
 
     from airflow.providers.common.compat.openlineage.facet import Dataset as 
OpenLineageDataset
 
+# Preserve the empty-authority "hdfs:///path" (fs.defaultFS) form through 
urlunsplit, like "file".
+if "hdfs" not in urllib.parse.uses_netloc:
+    urllib.parse.uses_netloc.append("hdfs")

Review Comment:
   I don’t think it’s a good idea to do this; uses_netloc is undocumented and 
should be considered private.
   
   When is this needed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to