jscheffl opened a new pull request, #68514: URL: https://github.com/apache/airflow/pull/68514
Re-apply #68078 by @diogosilva30 with fixes after a bad review, merge and reversion in #68481: Fixes from the original PR: * Not mentioning "Task SDK" anymore as this is _only_ about initializing stats correctly in API server * Remove caplog as we actually wanted to ban this * Double checked: no newsfragment. really. Why I am re-applying this PR: Because in all Airflow components the "Stats" is correctly initialized, but missing in API server. Original PR quote: > ## Why > > The API server serves the Edge Worker REST API (/edge_worker/v1/...). A worker heartbeat (PATCH /edge_worker/v1/worker/) runs set_state → set_metrics, which records edge_worker.* metrics through the Task SDK Stats singleton (resolved by the Edge provider via airflow.providers.common.compat). > > ### On main: hardening against a fragile import side effect > > The bug does not reproduce on current main. On main, task_runner.py imports serde at module level, which triggers serde._register() → Stats.initialize(...) as a side effect. That fires on any import airflow — including in the API server — so Stats gets initialized accidentally. > > However, this is fragile: it would silently regress if the module-level serde import in task_runner were ever made lazy, or if the mask-secrets import chain changed. The API server doesn't actually depend on serde, so relying on this side effect is not intentional. > > Adding an explicit Stats.initialize(...) in the FastAPI lifespan makes the dependency intentional and self-contained. It's a no-op on main (already initialized) and removes the accidental coupling. --- ##### Was generative AI tooling used to co-author this PR? <!-- If generative AI tooling has been used in the process of authoring this PR, please change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by". --> - [ ] Yes (please specify the tool below) <!-- Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) --> --- * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
