uranusjr commented on code in PR #68459:
URL: https://github.com/apache/airflow/pull/68459#discussion_r3412322190
##########
airflow-core/src/airflow/api_fastapi/common/parameters.py:
##########
@@ -316,16 +318,17 @@ class _SearchParam(BaseParam[str]):
is acceptable.
"""
- def __init__(self, attribute: ColumnElement, skip_none: bool = True) ->
None:
+ def __init__(self, attribute: ColumnElement, skip_none: bool = True,
pipe_as_or: bool = True) -> None:
super().__init__(skip_none=skip_none)
self.attribute: ColumnElement = attribute
+ self.pipe_as_or = pipe_as_or
def to_orm(self, select: Select) -> Select:
if self.value is None and self.skip_none:
return select
val_str = str(self.value)
- if "|" in val_str:
+ if self.pipe_as_or and "|" in val_str:
Review Comment:
Should this logic be extracted to a function?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
