amoghrajesh opened a new pull request, #68623:
URL: https://github.com/apache/airflow/pull/68623
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [x] Yes: claude sonnet 4.6
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
### Why
`ResumableJobMixin` had no standard on/off switch for crash recovery. When
`SparkSubmitOperator` with various modes was ported to resumability, I added a
`reconnect_on_retry` parameter, but any future resumable operator would need to
invent their own name, making the flag inconsistent across operators and
impossible to measure uniformly.
### What changed
- `ResumableJobMixin` now will have a `resume_on_retry: bool = True` class
attribute. When `False`, `execute_resumable()` skips all `task_state_store`
interaction and runs a plain submit/poll/result cycle. Operators no longer need
their own branching in `execute()` for the on/off case.
- `SparkSubmitOperator.reconnect_on_retry` is renamed to `resume_on_retry`.
The per-mode if/else branching in `execute()` is removed, all three tracking
paths (standalone, K8s, YARN) now call `execute_resumable(context)` directly.
### Impact on operators using resumability
No behavior change. `resume_on_retry` defaults to `True`, so crash recovery
is on by default exactly as before. The rename is the only user visible
difference.
### How to opt out
Set `resume_on_retry=False` on the task:
```python
SparkSubmitOperator(
task_id="my_spark_job",
application="my_app.jar",
resume_on_retry=False,
)
```
The operator will always submit a fresh job on retry with no
`task_state_store` interaction.
### Implementation note: why the mixin does not own the `__init__` parameter
The ideal design would have the mixin declare `resume_on_retry` in its own
`__init__` so every resumable operator inherits it automatically. This was
prototyped and ruled out.
It would required
- Patching `BaseOperatorMeta._apply_defaults` to traverse the full MRO when
building the signature cache, or
- Adding `resume_on_retry` to `BaseOperator.__init__` itself
Both touch core machinery that affects every operator in the project. Way
more blast radius than warranted for a single flag.
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
