kaxil commented on PR #68497: URL: https://github.com/apache/airflow/pull/68497#issuecomment-4719404891
> 1. Two example Dags in the same provider already use this exact guard pattern (`example_langchain_toolset_bridge.py` and `example_pydantic_ai_hook.py`) both do `try/except` with None fallback + if X is not None: guards. My PR just follows the same convention. If this pattern isn't the right approach, should those two be updated as well? I would be happy to undo their guards I don't see a `try..except` on either of those files: - https://github.com/apache/airflow/blob/98ea29a1e9f212d8cd004887be95070b41a3762e/providers/common/ai/src/airflow/providers/common/ai/example_dags/example_pydantic_ai_hook.py#L31 - https://github.com/apache/airflow/blob/98ea29a1e9f212d8cd004887be95070b41a3762e/providers/common/ai/src/airflow/providers/common/ai/example_dags/example_langchain_toolset_bridge.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
