ashb commented on code in PR #68633:
URL: https://github.com/apache/airflow/pull/68633#discussion_r3421886595
##########
.github/workflows/ci-image-checks.yml:
##########
@@ -160,6 +160,15 @@ jobs:
- name: "Show prek log on failure"
run: cat ~/.cache/prek/prek.log || true
if: failure()
+ - name: "Check commit messages are not Conventional Commits"
+ if: github.event_name == 'pull_request'
+ run: >
+ gh api
+ "repos/${{ github.repository }}/pulls/${{
github.event.pull_request.number }}/commits"
+ --paginate -q '.[].commit.message | split("\n")[0]'
+ | ./scripts/ci/prek/check_no_conventional_commit_message.py
--from-stdin
Review Comment:
Nit: We've already done a checkout here 5 steps above, so we should be able
to get this info from the local git checkout without hitting the API (which
hasn't been the most reliable thing of late)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
