dstandish commented on code in PR #68591:
URL: https://github.com/apache/airflow/pull/68591#discussion_r3424210757
##########
airflow-core/src/airflow/models/dagrun.py:
##########
@@ -1089,13 +1099,14 @@ def _emit_dagrun_span(self, state: DagRunState):
attributes["airflow.dag_run.logical_date"] =
str(self.logical_date)
if self.partition_key:
attributes["airflow.dag_run.partition_key"] =
str(self.partition_key)
+
# TODO: make the empty parent context optional. Default should be
to
- # nest the dag run span under the currently active parent span (by
- # omitting `context` here); only use the empty `context.Context()`
to
- # force a root span when Airflow itself initiates the run (e.g. dag
- # triggered via API, scheduler, or backfill). Today this forces a
- # root span unconditionally.
- # Tracked at https://github.com/apache/airflow/issues/67210
+ # nest the dag run span under the currently active parent span (by
+ # omitting `context` here); only use the empty
`context.Context()` to
+ # force a root span when Airflow itself initiates the run (e.g.
dag
+ # triggered via API, scheduler, or backfill). Today this forces a
+ # root span unconditionally.
+ # Tracked at https://github.com/apache/airflow/issues/67210
Review Comment:
This is just a driveby because pycharm / jetbrains likes their todos
indented for yellow highlighting.
##########
airflow-core/src/airflow/models/dagrun.py:
##########
@@ -1089,13 +1099,14 @@ def _emit_dagrun_span(self, state: DagRunState):
attributes["airflow.dag_run.logical_date"] =
str(self.logical_date)
if self.partition_key:
attributes["airflow.dag_run.partition_key"] =
str(self.partition_key)
+
# TODO: make the empty parent context optional. Default should be
to
- # nest the dag run span under the currently active parent span (by
- # omitting `context` here); only use the empty `context.Context()`
to
- # force a root span when Airflow itself initiates the run (e.g. dag
- # triggered via API, scheduler, or backfill). Today this forces a
- # root span unconditionally.
- # Tracked at https://github.com/apache/airflow/issues/67210
+ # nest the dag run span under the currently active parent span (by
+ # omitting `context` here); only use the empty
`context.Context()` to
+ # force a root span when Airflow itself initiates the run (e.g.
dag
+ # triggered via API, scheduler, or backfill). Today this forces a
+ # root span unconditionally.
+ # Tracked at https://github.com/apache/airflow/issues/67210
Review Comment:
This is just a driveby because pycharm / jetbrains likes their todos
indented for yellow highlighting.
If you don't like it I can remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
