uranusjr commented on PR #58543: URL: https://github.com/apache/airflow/pull/58543#issuecomment-4724937260
I think the idea is sound, but the implementation has too much special handling of specific timetables. Timetables are supposed to encapsulate scheduling logic. It is likely all isinstance branches should be rewritten as methods on the timetable base class (like how time-based timetables have differnt ways to calculate the next scheduled run with `next_dagrun_info`), and/or be conditionals based on feature flags (like how the base class has attributes like `periodic` to decide whether the timetable triggers runs on a schedule at all). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
