amoghrajesh commented on code in PR #68458:
URL: https://github.com/apache/airflow/pull/68458#discussion_r3425679188
##########
airflow-core/src/airflow/api_fastapi/execution_api/routes/dag_runs.py:
##########
@@ -158,6 +158,11 @@ def trigger_dag_run(
status.HTTP_400_BAD_REQUEST,
detail={"reason": "not_partitioned", "message": str(e)},
)
+ except InvalidPartitionKeyError as e:
+ raise HTTPException(
+ status.HTTP_400_BAD_REQUEST,
+ detail={"reason": "invalid_partition_key", "message": str(e)},
+ ) from e
Review Comment:
Needs test coverage
##########
airflow-core/src/airflow/timetables/simple.py:
##########
@@ -355,6 +356,36 @@ def partition_mapper_info(self) ->
list[PartitionMapperInfo]:
entries.append(PartitionMapperInfo(uri=s_asset_ref.uri,
is_rollup=mapper.is_rollup))
return entries
+ def _decode_partition_date(self, partition_key: str) -> datetime | None:
Review Comment:
Maybe we have to add a test with a `PartitionedAssetTimetable` whose asset
carries a temporal partition mapper and assert partition_date is populated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
