seanghaeli commented on PR #66608: URL: https://github.com/apache/airflow/pull/66608#issuecomment-4734936393
Updating my latest comment @ramitkataria. That commit "Fix scheduled DagRuns never getting a deadline" simultaneously fixes a pre-existing issue on main (the `VariableInterval` reference type) and an issue introduced by a prior commit in this PR. So I see your point about some orthogonal changes being packaged in. This one in particular, though, I'd lean toward keeping it self-contained: both fixes live in the same ~50-line deadline-creation block this PR already rewrites for the context work, so splitting the VariableInterval half into its own PR against main would almost certainly conflict with this PR's rewrite of the same lines. I've added a note to the description flagging that fix since it's the least obvious change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
