kaxil opened a new pull request #7002: [AIRFLOW-6425] Serialization: Add 
missing DAG parameters to Json Schema
URL: https://github.com/apache/airflow/pull/7002
 
 
   The following DAG currently fails:
   
   Schema Validation error when DAG.is_paused_upon_creation is set
   
   ```python
   def make_simple_dag():
       """Make very simple DAG to verify serialization result."""
       dag = DAG(
           dag_id='simple_dag',
           default_args={
               "retries": 1,
               "retry_delay": timedelta(minutes=5),
               "depends_on_past": False,
           },
           start_date=datetime(2019, 8, 1),
           is_paused_upon_creation=True,
       )
       BaseOperator(task_id='simple_task', dag=dag, owner='airflow')
       CustomOperator(task_id='custom_task', dag=dag)
       return {'simple_dag': dag}
   ```
   
   **Error**:
   ```
    jsonschema.exceptions.ValidationError: Additional properties are not 
allowed ('is_paused_upon_creation' was unexpected)
   ```
   
   *Reason*:
   
   `is_paused_upon_creation` is in `DAG.get_serialized_fields()` but not in the 
Schema definition.
   
   ---
   - [x] Description above provides context of the change
   - [x] Commit message contains 
[\[AIRFLOW-XXXX\]](https://issues.apache.org/jira/browse/AIRFLOW-XXXX) or 
`[AIRFLOW-XXXX]` for document-only changes
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to