1fanwang commented on code in PR #68480:
URL: https://github.com/apache/airflow/pull/68480#discussion_r3438001139
##########
providers/cncf/kubernetes/tests/unit/cncf/kubernetes/executors/test_kubernetes_executor.py:
##########
@@ -776,6 +776,323 @@ def test_run_next_pod_reconciliation_error(
finally:
kubernetes_executor.end()
+ @pytest.mark.skipif(
+ AirflowKubernetesScheduler is None, reason="kubernetes python package
is not installed"
+ )
+
@mock.patch("airflow.providers.cncf.kubernetes.kube_client.get_kube_client")
+ def test_kube_config_parses_async_pod_creation_options(self,
mock_get_kube_client):
+ """The two new config keys are parsed onto KubeConfig."""
+ with conf_vars(
+ {
+ ("kubernetes_executor", "async_pod_creation"): "True",
+ ("kubernetes_executor", "pod_creation_max_concurrency"): "7",
+ }
+ ):
+ executor = KubernetesExecutor()
+ assert executor.kube_config.async_pod_creation is True
+ assert executor.kube_config.pod_creation_max_concurrency == 7
Review Comment:
Agreed, removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
