jroachgolf84 commented on code in PR #67839:
URL: https://github.com/apache/airflow/pull/67839#discussion_r3439919099
##########
airflow-core/src/airflow/jobs/triggerer_job_runner.py:
##########
@@ -1313,6 +1321,11 @@ async def create_triggers(self):
trigger_instance.triggerer_job_id = self.job_id
trigger_instance.timeout_after = workload.timeout_after
+ if isinstance(trigger_instance, BaseEventTrigger) and
workload.watched_assets:
Review Comment:
Just gave this a try, and as much as I wanted it not to be the case, you
were right ;) . Here's the exception I was getting:
```
Traceback (most recent call last):
File "/opt/airflow/task-sdk/src/airflow/sdk/execution_time/supervisor.py",
line 890, in handle_requests
msg =
self.decoder.validate_python(self._deserialize_request(request.body))
File "/usr/python/lib/python3.10/site-packages/pydantic/type_adapter.py",
line 441, in validate_python
return self.validator.validate_python(
pydantic_core._pydantic_core.ValidationError: 1 validation error for
tagged-union[
TriggerStateChanges, GetConnection, DeleteVariable, GetVariable,
GetVariableKeys,
PutVariable, DeleteXCom, GetXCom, SetXCom, GetTICount, GetTaskStates,
GetDagRunState,
GetDRCount, GetPreviousTI, GetHITLDetailResponse, UpdateHITLDetail,
MaskSecret
]
Input tag 'GetAssetStateStoreByName' found using 'type' does not match any
of the expected tags:
'TriggerStateChanges', 'GetConnection', 'DeleteVariable', 'GetVariable',
'GetVariableKeys',
'PutVariable', 'DeleteXCom', 'GetXCom', 'SetXCom', 'GetTICount',
'GetTaskStates',
'GetDagRunState', 'GetDRCount', 'GetPreviousTI', 'GetHITLDetailResponse',
'UpdateHITLDetail',
'MaskSecret'
[type=union_tag_invalid, input_value={'name': 'generic_asset', ... 'type':
'GetAssetStateStoreByName'}, input_type=dict]
```
I'd like to get this out in a follow-up PR. I'll add that to the description
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
