ashb commented on code in PR #67572:
URL: https://github.com/apache/airflow/pull/67572#discussion_r3441694476
##########
airflow-core/src/airflow/config_templates/config.yml:
##########
@@ -2574,6 +2574,16 @@ scheduler:
type: float
example: ~
default: "30.0"
+ emit_serialized_dag_count_metric:
Review Comment:
How is this different to the existing `dagbag_size` metric?
##########
airflow-core/newsfragments/67572.feature.rst:
##########
Review Comment:
`SerializedDagModel.get_count()` is entirely an internal impl detail that is
not exposed to users; it shouldn't be in newsfragments.
##########
airflow-core/tests/unit/dag_processing/test_manager.py:
##########
@@ -3214,3 +3214,60 @@ def test_add_callback_to_queue_includes_team_name(self,
mock_incr, multi_team, t
manager._add_callback_to_queue(request)
mock_incr.assert_called_once_with("dag_processing.other_callback_count",
tags=expected_tags)
+
+
+class TestEmitMetrics:
Review Comment:
Please no extra test class -- add methods into the existing
TestDagProcessorManager.
##########
airflow-core/src/airflow/config_templates/config.yml:
##########
@@ -2574,6 +2574,16 @@ scheduler:
type: float
example: ~
default: "30.0"
+ emit_serialized_dag_count_metric:
Review Comment:
If we even need this (I'm not sure) it should be under the `dag_processor`
section, not `scheduler`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
