uranusjr commented on code in PR #68778:
URL: https://github.com/apache/airflow/pull/68778#discussion_r3449005589
##########
airflow-core/src/airflow/assets/manager.py:
##########
@@ -643,14 +645,22 @@ def _queue_partitioned_dags(
)
continue
+ # rerun_policy only applies to rollups (it decides what happens
when an
+ # upstream key re-arrives after the window already fired).
Non-rollup
+ # mappers have no such field; ``None`` keeps their legacy behavior.
+ rerun_policy = mapper.rerun_policy if is_rollup(mapper) else None
Review Comment:
I don’t like this. The mapper should instead decide on its own whether the
rerun policy applies to it or not. So `rerun_policy` should simply always be
*None* on any mapper that is not a rollup (and emit an error if the user tries
to set it to something else).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
