Vamsi-klu commented on PR #68008: URL: https://github.com/apache/airflow/pull/68008#issuecomment-4764226348
This closes the duplicate-scan window, but it now makes the heartbeat-timeout request the durable callback path for retryable tasks. Since the request is built before `handle_failure()` and does not set `task_callback_type`, a timed-out task with retries left can dispatch `on_failure_callback` instead of `on_retry_callback`. The regression test only covers `max_tries = 0`. Please set `task_callback_type` from retry eligibility before `send_callback()` and add a retryable heartbeat-timeout case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
