korex-f commented on PR #66633:
URL: https://github.com/apache/airflow/pull/66633#issuecomment-4766682314
Thanks for sharing #68779 @jason810496, having read through it, I agree it's
the cleaner approach to the provider side. The _closed flag correctly
distinguishes dictConfig mid-task closures from genuine teardown, which is
something my approach didn't handle.
Given this, I'd like to scope this PR down to task-sdk only:
- Issue 1 (log.py): getattr(remote, "processors") called before dictConfig
runs — #68779 doesn't fix this and it's the root cause
that makes Bug 2 worse
- Issue 3 (supervisor.py): _close_remote_log_handler context manager to
ensure the handler is flushed after process.wait() returns
That means reverting all provider changes from this PR and letting #68779
carry those.
Does that scope make sense @ashb? Happy to also drop the close() protocol
addition from RemoteLogIO per your comment, since #68779 handles the provider
side without needing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
