JustC0des commented on PR #68672: URL: https://github.com/apache/airflow/pull/68672#issuecomment-4767909203
Hi, thanks for the feedback and first review of the PR. I just pushed an update to tackle some of the blockers. - `_get_token()` now returns the token fetched from `_get_wif_databricks_token()` - Google ID token audience now uses `f"https://{self.host}""` to ensure the normalized format for the host is used - Added try-except block to catch `ImportError` and raise `AirflowOptionalProviderFeatureException` regarding the _a_get_token-method I am actually a bit unsure on how to handle this. From a first glimpse into what the google library offers it seems like they do not have a full async support yet. Any ideas on how to handle this? Would there be an option to only keep the current method and add the async method later or should this be handled with a workaround somehow? Thanks, Justin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
