jlaportebot commented on PR #68777: URL: https://github.com/apache/airflow/pull/68777#issuecomment-4771226957
Addressed both review comments from @pierrejeambrun: 1. **API models (ConnectionBody, ConnectionTestConnectionResponse)**: Replaced with constraints — simpler and more idiomatic for Pydantic v2. 2. **DB models (Connection, ConnectionTestRequest)**: Removed port validation entirely — as noted, validating at the database layer would break existing setups with invalid ports in the database. Validation now only happens at the API layer (incoming requests) and CLI. The CLI validation in and Task SDK validation are kept since they're user-facing entry points. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
