justinpakzad commented on PR #68789:
URL: https://github.com/apache/airflow/pull/68789#issuecomment-4773146445

   > Updated the PR in 
[cee3476](https://github.com/apache/airflow/commit/cee34764a366b170f5dd415fff4aa68532d1c896)
 to avoid DB access from task-sdk. The revised patch restores BaseXCom to the 
supervisor-comms-only path, adds server-side XComModel.get_one()/get_value() 
helpers, exposes XComModel from the common compat SDK for plugin extra links, 
and adds /links route coverage for a plugin-registered extra link reading XCom 
through XComModel.
   
   The new changes avoid the task-sdk db access issue, but I'm not sure 
exposing XComModel through the compat sdk is the correct approach either as 
it's mixing server and task imports in the same module. That being said, I'm 
not an expert here so I will defer to a maintainer.
   
   Just curious, did you take a look at the proposed solution on the issue? It 
avoids the need for any of these changes by having the plugin use XComModel and 
create_session directly from core


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to