yuseok89 commented on code in PR #67242:
URL: https://github.com/apache/airflow/pull/67242#discussion_r3456745543
##########
airflow-core/src/airflow/ui/src/pages/DagsList/DagsList.tsx:
##########
@@ -299,9 +356,19 @@ export const DagsList = () => {
</Heading>
<DagImportErrors iconOnly />
</HStack>
- {display === "card" ? (
- <SortSelect handleSortChange={handleSortChange} orderBy={orderBy}
/>
- ) : undefined}
+ <HStack>
+ <TimeRangeSelector
+ defaultValue={DEFAULT_HOURS}
+ endDate={endDate}
+ setEndDate={setEndDate}
+ setStartDate={setStartDate}
+ showDateRange={false}
+ startDate={startDate}
Review Comment:
> Something looks weird.
>
> I have tons of 'success' TIs for those dags, yet 0 appears, where I would
expect 1k+ everywhere.
>
> I checked the date looks correct.
I think this time range selector is why it felt weird to you.
A 24h filter is applied, so only states within the last 24h are being
counted.
Just to note, these badges count DAG runs by state, not task instances.
This filter was added around the May 23 review.
At this point I'd like to discuss again whether it's really a needed filter.
Personally, I think we might be fine without it.
The Airflow 2 DAGs list counted runs across all time too, so it'd probably
be less confusing for users.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
