mobuchowski commented on code in PR #66992:
URL: https://github.com/apache/airflow/pull/66992#discussion_r3458688541
##########
providers/openlineage/tests/unit/openlineage/extractors/test_manager.py:
##########
@@ -316,6 +316,78 @@ def get_openlineage_facets_on_start(self):
assert metadata.outputs == []
[email protected]("hook_lineage", [True, False])
+def test_extract_metadata_no_extractor_emits_unknown_source_and_inlets_outlets(
+ hook_lineage, hook_lineage_collector
+):
+ """
+ Regression: when no extractor matches and no hook lineage is collected,
the no-extractor
+ fallback must still emit the ``unknownSourceAttribute`` run facet AND
extract manually
Review Comment:
Test for hook lineage would make sense too
##########
providers/openlineage/src/airflow/providers/openlineage/utils/utils.py:
##########
@@ -1324,6 +1325,7 @@ def get_airflow_run_facet(
task_instance: TaskInstance,
task: BaseOperator,
task_uuid: str,
+ include_full_task_info: bool = False,
Review Comment:
Caller at line 289 does not pass this argument - is it by design?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
