ashb commented on code in PR #68779:
URL: https://github.com/apache/airflow/pull/68779#discussion_r3460503821
##########
providers/amazon/src/airflow/providers/amazon/aws/log/cloudwatch_task_handler.py:
##########
@@ -127,16 +144,19 @@ def processors(self) -> tuple[structlog.typing.Processor,
...]:
logRecordFactory = getLogRecordFactory()
# The handler MUST be initted here, before the processor is actually
used to log anything.
# Otherwise, logging that occurs during the creation of the handler
can create infinite loops.
- _handler = self.handler
+ _ = self.handler
Review Comment:
This forces the handler property to be created and cached when called, often
called vivification. Yes needed as per the comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
