lohitkolluri commented on PR #67900: URL: https://github.com/apache/airflow/pull/67900#issuecomment-4781977754
Hey Pierre, I went through your comments. All of them have been addressed in the latest commit: - Removed the `with_row_locks` on DagModel — agreed it wasn't worth the deadlock risk for a SQLite-only concern - That made the `utils/sqlalchemy.py` change moot too, so that's reverted to just adding the SQLite lock check to `is_lock_not_available_error` - `is_lock_not_available_error` is now reused in both `create_backfill` and `create_backfill_dry_run` - No redundant `session.commit()` in the route handler - Test docstrings cleaned up — no issue references, just describes what the test does Would appreciate a quick re-review when you get a chance. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
