bugraoz93 commented on PR #68856: URL: https://github.com/apache/airflow/pull/68856#issuecomment-4782761440
> Cool. Just for extra context, [this](https://github.com/apache/airflow/blob/92290dbd64f52205b516668db29fd437435b7dbe/providers/fab/src/airflow/providers/fab/auth_manager/fab_auth_manager.py#L316) is why I was going to revert. We can't just "pick the first" user to attribute calls to - that makes the tracked user in the audit log basically useless. > > I also have concerns around requiring explicit tokens to be set for non-simple/fab auth manager users. But I never fully formed my argument on that one. > > Just keep in mind, this change has already been released in FAB. So any redo etc will need to take into account that that helper is in the wild now and really can't be used... I should have overlook that part. In my mind we should have create a dummy user and use that with some admin cli tracing. Totally agree, that shouldn't be the case 🤦My bad, thanks Jed for checking in and was going to revert! That concern is also valid but without a valid user crafted API communication not really possible. There could be better way for sure. That won't be a concern anymore as direction changed. I was wondering the reason to follow up better. I will make this revert ready in an hour or so. Not on pc unfortunately. Maybe we can yank only fab as others are just useless rather wrong logic in fab? After reverting I can help releasing providers again with accelerated vote. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
