ellisms commented on code in PR #64274:
URL: https://github.com/apache/airflow/pull/64274#discussion_r3462926650
##########
providers/amazon/src/airflow/providers/amazon/aws/waiters/neptune_analytics.json:
##########
@@ -0,0 +1,38 @@
+{
+ "version": 2,
+ "waiters": {
+
+ "import_task_cancelled":{
+ "operation": "GetImportTask",
+ "delay": 30,
+ "maxAttempts": 60,
+ "acceptors": [
+ {
+ "matcher": "path",
+ "argument": "status",
+ "expected": "SUCCEEDED",
+ "state": "success"
+ },
+ {
+ "matcher": "path",
+ "argument": "status",
+ "expected": "CANCELLED",
+ "state": "success"
+ },
+ {
+ "matcher": "path",
+ "argument": "status",
+ "expected": "ERROR_ENCOUNTERED",
+ "state": "error"
+ },
+ {
+ "matcher": "path",
+ "argument": "status",
Review Comment:
Do you mean accepting FAILED as successful? If so, I made the change based
on [this
comment](https://github.com/apache/airflow/pull/64274#discussion_r3283359724).
I'm on the fence about it and I could go either way. Would like other's input.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
