mansfieldj3 commented on code in PR #67218:
URL: https://github.com/apache/airflow/pull/67218#discussion_r3463594632
##########
providers/google/src/airflow/providers/google/cloud/hooks/bigquery.py:
##########
@@ -345,6 +399,9 @@ def _get_pandas_df(
if dialect is None:
dialect = "legacy" if self.use_legacy_sql else "standard"
+ if self.http_proxy or self.https_proxy:
+ return self.get_client().query(sql,
timeout=10).to_dataframe(create_bqstorage_client=False)
Review Comment:
good shout, dialect / kwargs were added back in and timeout moved to default
to 60 rather than 10 if undefine + be able to be defined by the user in the
function if desired
##########
providers/google/src/airflow/providers/google/cloud/hooks/bigquery.py:
##########
@@ -345,6 +399,9 @@ def _get_pandas_df(
if dialect is None:
dialect = "legacy" if self.use_legacy_sql else "standard"
+ if self.http_proxy or self.https_proxy:
+ return self.get_client().query(sql,
timeout=10).to_dataframe(create_bqstorage_client=False)
Review Comment:
good shout, dialect / kwargs were added back in and timeout moved to default
to 60 rather than 10 if undefined + be able to be defined by the user in the
function if desired
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
