seanghaeli commented on PR #68922: URL: https://github.com/apache/airflow/pull/68922#issuecomment-4791753003
Thanks @SameerMesiah97 — all applied: - Trimmed both docstrings (the `_resume_if_paused` method and the `resume_if_paused` param) to your shorter versions; moved the non-transactional context into a comment in the method as you suggested. - Replaced both silent `return`s with the log lines you proposed (cluster-not-found, and non-paused "skipping resume"). - Added a test (`test_delete_missing_cluster_skips_resume`) covering the `ClusterNotFoundFault` branch — asserts a missing cluster is ignored rather than raised. Left the test docstrings as-is for now since you flagged that as non-blocking. Pushed. Drafted-by: Claude Code (Opus via Claude Code) on behalf of Sean Ghaeli -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
