potiuk commented on code in PR #66952:
URL: https://github.com/apache/airflow/pull/66952#discussion_r3470378494
##########
providers/apache/beam/pyproject.toml:
##########
@@ -61,7 +61,11 @@ requires-python = ">=3.10"
dependencies = [
"apache-airflow>=2.11.0",
"apache-airflow-providers-common-compat>=1.12.0",
- "apache-beam>=2.69.0",
+ "apache-beam>=2.72.0",
+ # For Python>=3.11, the apache-beam package depends on envoy-data-plane.
+ # Currently, there is only one compatible version(1.0.3) of
envoy-data-plane available for these
+ # Python versions, and it explicitly requires a prerelease version of
betterproto.
+ "betterproto==2.0.0b6; python_version >= '3.11'",
Review Comment:
Not a big fan either.
But I think thee newer version of envoy-data-plane has been questioned by
others for example here: https://github.com/apache/beam/issues/37854
And I see that this is what latest beam has:
```
envoy-data-plane<2,>=1.0.3; python_version >= "3.11"
```
And the 2.1.0 version of envoy-data-plane uses already betterproto2 - which
is a maintained replacement of betterproto.
So maybe we can ask `apache-beam` to upgrade to the `envoy-data-plane>2` ?
##########
providers/apache/beam/pyproject.toml:
##########
@@ -61,7 +61,11 @@ requires-python = ">=3.10"
dependencies = [
"apache-airflow>=2.11.0",
"apache-airflow-providers-common-compat>=1.12.0",
- "apache-beam>=2.69.0",
+ "apache-beam>=2.72.0",
+ # For Python>=3.11, the apache-beam package depends on envoy-data-plane.
+ # Currently, there is only one compatible version(1.0.3) of
envoy-data-plane available for these
+ # Python versions, and it explicitly requires a prerelease version of
betterproto.
+ "betterproto==2.0.0b6; python_version >= '3.11'",
Review Comment:
Not a big fan either.
But I think thee newer version of envoy-data-plane has been questioned by
others for example here: https://github.com/apache/beam/issues/37854
And I see that this is what latest beam has:
```
envoy-data-plane<2,>=1.0.3; python_version >= "3.11"
```
And the 2.1.0 version of envoy-data-plane uses already betterproto2 - which
is a maintained replacement of betterproto.
So maybe we can ask `apache-beam` to upgrade to the `envoy-data-plane>=2` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
