somaz94 commented on code in PR #68552:
URL: https://github.com/apache/airflow/pull/68552#discussion_r3471765081
##########
chart/tests/chart_utils/helm_template_generator.py:
##########
@@ -138,9 +138,14 @@ def render_chart(
chart_dir=None,
kubernetes_version=DEFAULT_KUBERNETES_VERSION,
namespace=None,
+ api_versions=None,
):
"""
Function that renders a helm chart into dictionaries. For helm chart
testing only
+
+ ``api_versions`` is passed to ``helm template --api-versions`` so that
templates
+ gated on ``.Capabilities.APIVersions.Has`` (e.g. Gateway API CRDs) can be
rendered
+ offline, where Helm cannot query a live cluster for installed API groups.
Review Comment:
Applied — dropped the `api_versions` docstring paragraph.
##########
chart/templates/api-server/api-server-httproute.yaml:
##########
@@ -20,7 +20,13 @@
##################################
## Airflow API Server HTTPRoute
##################################
-{{- if and .Values.apiServer.enabled .Values.httpRoute.apiServer.enabled }}
+{{- if and .Values.apiServer.enabled .Values.apiServer.httpRoute.enabled }}
+{{- if .Values.ingress.apiServer.enabled }}
+{{- fail "`apiServer.httpRoute.enabled` and `ingress.apiServer.enabled` are
both set to `true`. HTTPRoute (Gateway API) is an alternative to the API server
Ingress; enable only one of them." }}
+{{- end }}
Review Comment:
Done — added the reciprocal guard in `api-server-ingress.yaml` so enabling
both fails from the ingress side too. Updated the conflict test to assert on
the shared "enable only one of them" phrase since either guard may fire first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
