jroachgolf84 opened a new pull request, #68997:
URL: https://github.com/apache/airflow/pull/68997

   ## Description
   
   In the `ExternalTaskSensor`, the `poll_interval` was being instantiated and 
being used rather than the `poke_interval` parameter. Users passing in 
`poke_interval` were not having that value respected (despite `poke_interval` 
being an inherited parameter from `BaseSensorOperator`).
   
   This PR removes `poll_interval` from the `ExternalTaskSensor` and ensures 
that the value set for `poke_interval` is respected.
   
   closes: #68990 
   
   ## Testing
   
   Six new unit-tests were added as part of this PR. These unit tests ensure 
that:
   
   * `poke_interval` is properly set upon init
   * Setting `poll_interval` is no longer supported
   * The new `poke_interval` passes through to the Trigger when Operator is 
used in a deferrable fashion
   
   These tests can be run with the following command:
   
   
   ```bash
   breeze testing providers-tests 
providers/standard/tests/unit/standard/sensors/test_external_task_sensor.py
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to